The following document contains the results of PMD 4.3.
| Violation | Line |
|---|---|
| All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. | 55 - 997 |
| Violation | Line |
|---|---|
| Avoid if (x != y) ..; else ..; | 114 - 231 |
| Avoid empty catch blocks | 125 - 126 |
| Violation | Line |
|---|---|
| Avoid if (x != y) ..; else ..; | 41 - 77 |
| Violation | Line |
|---|---|
| All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. | 32 - 46 |
| Violation | Line |
|---|---|
| Avoid if (x != y) ..; else ..; | 86 - 90 |
| These nested if statements could be combined | 219 - 221 |
| An empty method in an abstract class should be abstract instead | 286 - 288 |
| Violation | Line |
|---|---|
| Avoid reassigning parameters such as 'name' | 41 |
| Switch statements should have a default label | 59 - 72 |
| A switch statement does not contain a break | 59 - 72 |
| Overridable method 'setCharset' called during object construction | 76 |
| Violation | Line |
|---|---|
| An empty method in an abstract class should be abstract instead | 136 - 138 |
| An empty method in an abstract class should be abstract instead | 191 - 193 |
| Violation | Line |
|---|---|
| Avoid empty catch blocks | 94 - 96 |
| Avoid if (x != y) ..; else ..; | 159 |
| Avoid empty catch blocks | 161 - 163 |
| Avoid empty catch blocks | 173 - 175 |
| Violation | Line |
|---|---|
| These nested if statements could be combined | 198 - 209 |
| Switch statements should have a default label | 228 - 235 |
| A switch statement does not contain a break | 228 - 235 |
| Avoid reassigning parameters such as 'val' | 248 |
| Violation | Line |
|---|---|
| Avoid reassigning parameters such as 'name' | 67 |
| Switch statements should have a default label | 84 - 90 |
| A switch statement does not contain a break | 84 - 90 |
| Overridable method 'setValue' called during object construction | 98 |
| Avoid reassigning parameters such as 'value' | 332 |
| Switch statements should have a default label | 342 - 347 |
| A switch statement does not contain a break | 342 - 347 |
| Violation | Line |
|---|---|
| Overridable method 'setContent' called during object construction | 37 |
| Violation | Line |
|---|---|
| Private field 'useDisk' could be made final; it is only initialized in the declaration or constructor. | 44 |
| Private field 'checkSize' could be made final; it is only initialized in the declaration or constructor. | 46 |
| Violation | Line |
|---|---|
| Overridable method 'setProtocolVersion' called during object construction | 45 |
| Avoid reassigning parameters such as 'content' | 98 |
| Violation | Line |
|---|---|
| Overridable method 'setMethod' called during object construction | 42 |
| Overridable method 'setUri' called during object construction | 43 |
| Violation | Line |
|---|---|
| Overridable method 'setStatus' called during object construction | 40 |
| Violation | Line |
|---|---|
| Overridable method 'setValue' called during object construction | 58 |
| Violation | Line |
|---|---|
| Overridable method 'setFilename' called during object construction | 49 |
| Overridable method 'setContentType' called during object construction | 50 |
| Overridable method 'setContentTransferEncoding' called during object construction | 51 |
| Avoid if (x != y) ..; else ..; | 132 |
| Violation | Line |
|---|---|
| Document empty constructor | 107 - 108 |
| Switch statements should have a default label | 186 - 220 |
| A switch with less than 3 branches is inefficient, use a if statement instead. | 186 - 220 |
| These nested if statements could be combined | 212 - 217 |
| Violation | Line |
|---|---|
| A class which only has private constructors should be final | 28 - 176 |
| Switch statements should have a default label | 90 - 96 |
| A switch statement does not contain a break | 90 - 96 |
| Switch statements should have a default label | 114 - 121 |
| A switch with less than 3 branches is inefficient, use a if statement instead. | 114 - 121 |
| Switch statements should have a default label | 124 - 154 |
| Switch statements should have a default label | 126 - 133 |
| A switch with less than 3 branches is inefficient, use a if statement instead. | 126 - 133 |
| A switch with less than 3 branches is inefficient, use a if statement instead. | 136 - 143 |
| Violation | Line |
|---|---|
| Avoid if (x != y) ..; else ..; | 73 - 77 |
| Avoid if (x != y) ..; else ..; | 110 - 132 |
| Avoid if (x != y) ..; else ..; | 111 - 129 |
| Violation | Line |
|---|---|
| Avoid if (x != y) ..; else ..; | 100 - 137 |
| Deeply nested if..then statements are hard to read | 127 - 131 |
| Avoid if (x != y) ..; else ..; | 143 - 165 |
| Avoid if (x != y) ..; else ..; | 144 - 162 |
| Violation | Line |
|---|---|
| Avoid if (x != y) ..; else ..; | 855 - 861 |
| Use equals() to compare object references. | 961 |
| Use equals() to compare object references. | 977 |
| Violation | Line |
|---|---|
| Switch statements should have a default label | 396 - 399 |
| A switch statement does not contain a break | 396 - 399 |
| Avoid if (x != y) ..; else ..; | 500 - 506 |
| Substitute calls to size() == 0 (or size() != 0) with calls to isEmpty() | 500 |
| Avoid empty if statements | 504 - 506 |
| Switch statements should have a default label | 536 - 546 |
| A switch with less than 3 branches is inefficient, use a if statement instead. | 536 - 546 |
| Avoid reassigning parameters such as 'hex' | 570 |
| Avoid reassigning parameters such as 'hex' | 570 |
| Violation | Line |
|---|---|
| Avoid if (x != y) ..; else ..; | 90 - 98 |
| Violation | Line |
|---|---|
| Avoid reassigning parameters such as 'name' | 105 |
| Avoid if (x != y) ..; else ..; | 116 - 120 |
| Avoid reassigning parameters such as 'name' | 132 |
| Violation | Line |
|---|---|
| Overridable method 'parseBodyMultipart' called during object construction | 187 |
| These nested if statements could be combined | 368 - 370 |
| Substitute calls to size() == 0 (or size() != 0) with calls to isEmpty() | 372 |
| A high ratio of statements to labels in a switch statement. Consider refactoring. | 447 - 513 |
| Avoid empty if statements | 537 - 539 |
| A high ratio of statements to labels in a switch statement. Consider refactoring. | 578 - 653 |
| Avoid empty if statements | 677 - 679 |
| A switch statement does not contain a break | 759 - 850 |
| Avoid if (x != y) ..; else ..; | 1067 - 1077 |
| Avoid if (x != y) ..; else ..; | 1079 - 1087 |
| Avoid if (x != y) ..; else ..; | 1152 - 1153 |
| Avoid empty if statements | 1741 - 1743 |
| Document empty constructor | 1859 - 1860 |
| Document empty constructor | 1905 - 1906 |
| Document empty constructor | 1941 - 1942 |
| Violation | Line |
|---|---|
| Substitute calls to size() == 0 (or size() != 0) with calls to isEmpty() | 411 |
| Substitute calls to size() == 0 (or size() != 0) with calls to isEmpty() | 436 |
| Avoid if (x != y) ..; else ..; | 550 - 555 |
| Avoid if (x != y) ..; else ..; | 580 - 596 |
| When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 604 - 605 |
| Avoid empty if statements | 605 - 607 |
| When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 607 - 608 |
| Avoid empty if statements | 608 - 610 |
| Avoid empty if statements | 639 - 641 |
| Avoid if (x != y) ..; else ..; | 841 - 846 |
| Avoid if (x != y) ..; else ..; | 848 - 854 |
| Violation | Line |
|---|---|
| Switch statements should have a default label | 289 - 390 |
| Switch statements should have a default label | 434 - 439 |
| A switch statement does not contain a break | 434 - 439 |
| A switch with less than 3 branches is inefficient, use a if statement instead. | 434 - 439 |
| Violation | Line |
|---|---|
| Avoid reassigning parameters such as 'text' | 56 |
| Position literals first in String comparisons | 62 |
| Position literals first in String comparisons | 65 |
| Avoid reassigning parameters such as 'text' | 96 |
| Avoid reassigning parameters such as 'protocolName' | 139 |
| Violation | Line |
|---|---|
| Document empty constructor | 40 - 41 |
| Violation | Line |
|---|---|
| Overridable method 'setValue' called during object construction | 47 |
| Violation | Line |
|---|---|
| Overridable method 'setFilename' called during object construction | 43 |
| Overridable method 'setContentType' called during object construction | 44 |
| Overridable method 'setContentTransferEncoding' called during object construction | 45 |
| Avoid if (x != y) ..; else ..; | 120 |
| Violation | Line |
|---|---|
| Private field 'limitSize' could be made final; it is only initialized in the declaration or constructor. | 36 |
| New exception is thrown in catch block, original stack trace may be lost | 57 |
| These nested if statements could be combined | 73 - 81 |
| These nested if statements could be combined | 144 - 149 |
| These nested if statements could be combined | 157 - 162 |
| Violation | Line |
|---|---|
| Private field 'limitSize' could be made final; it is only initialized in the declaration or constructor. | 36 |
| Private field 'definedSize' could be made final; it is only initialized in the declaration or constructor. | 38 |
| These nested if statements could be combined | 59 - 70 |
| These nested if statements could be combined | 148 - 156 |
| These nested if statements could be combined | 164 - 172 |
| Violation | Line |
|---|---|
| Avoid if (x != y) ..; else ..; | 158 - 163 |
| Avoid if (x != y) ..; else ..; | 254 - 268 |
| These nested if statements could be combined | 265 - 267 |
| Switch statements should have a default label | 333 - 340 |
| A switch with less than 3 branches is inefficient, use a if statement instead. | 333 - 340 |
| New exception is thrown in catch block, original stack trace may be lost | 384 |
| Violation | Line |
|---|---|
| New exception is thrown in catch block, original stack trace may be lost | 135 |
| Violation | Line |
|---|---|
| Private field 'addressInt' could be made final; it is only initialized in the declaration or constructor. | 30 |
| Avoid empty catch blocks | 48 - 50 |
| Violation | Line |
|---|---|
| Private field 'addressBigInt' could be made final; it is only initialized in the declaration or constructor. | 38 |
| Avoid empty catch blocks | 56 - 58 |
| Deeply nested if..then statements are hard to read | 80 - 82 |
| Violation | Line |
|---|---|
| Switch statements should have a default label | 94 - 135 |
| Avoid if (x != y) ..; else ..; | 107 - 133 |
| Avoid if (x != y) ..; else ..; | 115 - 119 |
| Violation | Line |
|---|---|
| Document empty constructor | 82 - 83 |
| Violation | Line |
|---|---|
| Private field 'cidr' could be made final; it is only initialized in the declaration or constructor. | 61 |
| Avoid empty catch blocks | 177 - 178 |
| Violation | Line |
|---|---|
| Private field 'isAllowRule' could be made final; it is only initialized in the declaration or constructor. | 33 |
| Violation | Line |
|---|---|
| Private field 'isAllowRule' could be made final; it is only initialized in the declaration or constructor. | 30 |
| Violation | Line |
|---|---|
| These nested if statements could be combined | 91 - 99 |
| Deeply nested if..then statements are hard to read | 91 - 99 |
| These nested if statements could be combined | 93 - 98 |
| Violation | Line |
|---|---|
| An empty method in an abstract class should be abstract instead | 328 - 330 |
| Deeply nested if..then statements are hard to read | 395 - 403 |
| Deeply nested if..then statements are hard to read | 415 - 417 |
| Avoid if (x != y) ..; else ..; | 512 |
| Violation | Line |
|---|---|
| These nested if statements could be combined | 165 - 168 |
| Violation | Line |
|---|---|
| Overridable method 'createGlobalTrafficCounter' called during object construction | 88 |
| Overridable method 'createGlobalTrafficCounter' called during object construction | 99 |
| Overridable method 'createGlobalTrafficCounter' called during object construction | 108 |
| Overridable method 'createGlobalTrafficCounter' called during object construction | 116 |
| Overridable method 'createGlobalTrafficCounter' called during object construction | 131 |
| Overridable method 'createGlobalTrafficCounter' called during object construction | 143 |
| Overridable method 'createGlobalTrafficCounter' called during object construction | 154 |
| Overridable method 'createGlobalTrafficCounter' called during object construction | 164 |