PMD Results

The following document contains the results of PMD 4.3.

Files

openr66/client/AbstractBusinessRequest.java

Violation	Line
Possible unsafe assignment to a non-final static field in a constructor.	56
Avoid empty catch blocks	88 - 89
Singleton is not thread safe	129 - 131

openr66/client/AbstractTransfer.java

Violation	Line
Possible unsafe assignment to a non-final static field in a constructor.	52
Avoid if (x != y) ..; else ..;	120 - 148
When instantiating a SimpleDateFormat object, specify a Locale	160
Static DateFormatter objects should be accessed in a synchronized manner	236
Avoid empty catch blocks	238 - 239
Singleton is not thread safe	250 - 252
Avoid if (x != y) ..; else ..;	253 - 267
Singleton is not thread safe	253 - 267
Singleton is not thread safe	255 - 267

openr66/client/DirectTransfer.java

Violation	Line
Avoid empty catch blocks	91 - 92
Avoid empty catch blocks	117 - 118
Avoid if (x != y) ..; else ..;	158
Avoid if (x != y) ..; else ..;	164

openr66/client/Message.java

Violation	Line
Possible unsafe assignment to a non-final static field in a constructor.	57
Singleton is not thread safe	186 - 188

openr66/client/ProgressBarTransfer.java

Violation	Line
Avoid empty catch blocks	144 - 145
Avoid empty catch blocks	173 - 174

openr66/client/RecvThroughClient.java

Violation	Line
These nested if statements could be combined	148 - 153
Avoid empty catch blocks	151 - 152

openr66/client/RequestInformation.java

Violation	Line
Singleton is not thread safe	201 - 203

openr66/client/RequestTransfer.java

Violation	Line
Avoid empty catch blocks	287 - 288
Singleton is not thread safe	356 - 358

openr66/client/SendThroughClient.java

Violation	Line
These nested if statements could be combined	229 - 234
Avoid empty catch blocks	232 - 233
Avoid empty catch blocks	274 - 275
These nested if statements could be combined	289 - 294
Avoid empty catch blocks	292 - 293
Avoid empty catch blocks	312 - 313

openr66/client/SubmitTransfer.java

Violation	Line
Avoid if (x != y) ..; else ..;	105 - 110

openr66/commander/ClientRunner.java

Violation	Line
Avoid empty catch blocks	123 - 124
Avoid if (x != y) ..; else ..;	162 - 186
Avoid if (x != y) ..; else ..;	168
Avoid if (x != y) ..; else ..;	172 - 173
Avoid if (x != y) ..; else ..;	176 - 177
Avoid empty catch blocks	385 - 386
These nested if statements could be combined	431 - 434
Avoid empty catch blocks	573 - 574

openr66/commander/Commander.java

Violation	Line
Avoid empty catch blocks	156 - 157
Avoid empty catch blocks	157 - 158
Avoid empty catch blocks	203 - 204
Avoid empty catch blocks	210 - 211
Avoid if (x != y) ..; else ..;	224 - 237
Avoid empty catch blocks	244 - 245
Avoid empty catch blocks	251 - 252
Avoid empty catch blocks	258 - 259
Avoid if (x != y) ..; else ..;	273 - 294
Avoid empty catch blocks	300 - 301
Avoid empty catch blocks	307 - 308
Avoid empty catch blocks	314 - 315
Avoid if (x != y) ..; else ..;	328 - 348
Avoid empty catch blocks	354 - 355
Avoid empty catch blocks	361 - 362
Avoid empty catch blocks	368 - 369
Avoid empty catch blocks	375 - 376
Avoid empty catch blocks	417 - 418
Avoid empty catch blocks	424 - 425
Avoid empty catch blocks	431 - 432
Avoid empty catch blocks	449 - 450

openr66/commander/InternalRunner.java

Violation	Line
Perhaps 'workQueue' could be replaced by a local variable.	61
Avoid empty catch blocks	99 - 100

openr66/configuration/AuthenticationFileBasedConfiguration.java

Violation	Line
All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning.	57 - 298
Avoid if (x != y) ..; else ..;	219 - 223

openr66/configuration/FileBasedConfiguration.java

Violation	Line
All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning.	78 - 1872
Avoid if (x != y) ..; else ..;	614 - 619
Avoid if (x != y) ..; else ..;	621 - 628
Avoid if (x != y) ..; else ..;	636 - 645
Avoid if (x != y) ..; else ..;	670 - 686
Avoid if (x != y) ..; else ..;	689 - 693
Avoid if (x != y) ..; else ..;	706 - 711
These nested if statements could be combined	713 - 716
Avoid if (x != y) ..; else ..;	720 - 725
Avoid if (x != y) ..; else ..;	824 - 832
Avoid empty catch blocks	982 - 983
Avoid if (x != y) ..; else ..;	1066 - 1089
Avoid if (x != y) ..; else ..;	1208 - 1212
Avoid if (x != y) ..; else ..;	1216 - 1220
These nested if statements could be combined	1491 - 1494
These nested if statements could be combined	1539 - 1542
These nested if statements could be combined	1610 - 1613
These nested if statements could be combined	1621 - 1624
These nested if statements could be combined	1691 - 1694
These nested if statements could be combined	1706 - 1709
These nested if statements could be combined	1779 - 1782
These nested if statements could be combined	1790 - 1793

openr66/configuration/RuleFileBasedConfiguration.java

Violation	Line
All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning.	62 - 629
Avoid if (x != y) ..; else ..;	425 - 434

openr66/context/authentication/R66Auth.java

Violation	Line
Avoid if (x != y) ..; else ..;	221 - 222
Avoid empty catch blocks	255 - 256

openr66/context/filesystem/R66Dir.java

Violation	Line
Use block level rather than method level synchronization	76 - 94
New exception is thrown in catch block, original stack trace may be lost	89 - 90

openr66/context/filesystem/R66File.java

Violation	Line
Avoid empty catch blocks	488 - 489
Avoid empty catch blocks	541 - 542

openr66/context/filesystem/R66Restart.java

Violation	Line
New exception is thrown in catch block, original stack trace may be lost	54 - 55

openr66/context/R66DefaultBusinessFactory.java

Violation	Line
Document empty method	50 - 51

openr66/context/R66Result.java

Violation	Line
Avoid if (x != y) ..; else ..;	97
Avoid if (x != y) ..; else ..;	98
Avoid if (x != y) ..; else ..;	99
Avoid if (x != y) ..; else ..;	107 - 111

openr66/context/R66Session.java

Violation	Line
Private field 'extendedProtocol' could be made final; it is only initialized in the declaration or constructor.	118
These nested if statements could be combined	182 - 194
These nested if statements could be combined	183 - 193
Deeply nested if..then statements are hard to read	183 - 193
Avoid empty catch blocks	190 - 191
Avoid empty catch blocks	191 - 192
Avoid empty catch blocks	208 - 209
Avoid if (x != y) ..; else ..;	319 - 324
Avoid empty catch blocks	359 - 360
Avoid if (x != y) ..; else ..;	364 - 368
Avoid empty catch blocks	533 - 534
Avoid empty catch blocks	539 - 540
Avoid empty catch blocks	545 - 546
Avoid empty catch blocks	551 - 552
Avoid empty catch blocks	576 - 578
Avoid empty catch blocks	593 - 594
Avoid if (x != y) ..; else ..;	630 - 673
Avoid empty if statements	632 - 634
Avoid empty catch blocks	658 - 660
Avoid empty catch blocks	665 - 666
These nested if statements could be combined	729 - 735
Avoid if (x != y) ..; else ..;	765 - 772
Avoid empty catch blocks	823 - 824
Avoid empty catch blocks	842 - 843
Avoid empty catch blocks	851 - 852
Avoid if (x != y) ..; else ..;	870
Avoid if (x != y) ..; else ..;	871
Avoid if (x != y) ..; else ..;	872
Avoid if (x != y) ..; else ..;	873

openr66/context/task/AbstractExecJavaTask.java

Violation	Line
Avoid empty catch blocks	76 - 77
Avoid empty catch blocks	113 - 114
These nested if statements could be combined	124 - 128

openr66/context/task/AbstractTask.java

Violation	Line
Avoid if (x != y) ..; else ..;	286 - 295
When instantiating a SimpleDateFormat object, specify a Locale	302
When instantiating a SimpleDateFormat object, specify a Locale	305
Avoid if (x != y) ..; else ..;	318 - 324
Avoid empty catch blocks	342 - 343
Avoid empty catch blocks	348 - 349
Avoid empty catch blocks	354 - 355
Avoid empty catch blocks	360 - 361
Avoid empty catch blocks	366 - 367
Avoid empty catch blocks	372 - 373
Avoid empty catch blocks	378 - 379
Avoid empty catch blocks	384 - 385

openr66/context/task/AllLineReader.java

Violation	Line
Avoid empty catch blocks	60 - 64
Avoid empty catch blocks	67 - 68

openr66/context/task/ExecJavaTask.java

Violation	Line
Avoid if (x != y) ..; else ..;	115 - 121
Avoid empty while statements	123
Avoid empty while statements	127

openr66/context/task/ExecMoveTask.java

Violation	Line
These nested if statements could be combined	109 - 116
Avoid empty catch blocks	130 - 131
Avoid empty catch blocks	168 - 169
Avoid empty catch blocks	173 - 174
Avoid empty catch blocks	183 - 184
Avoid empty catch blocks	188 - 189
Avoid empty catch blocks	199 - 200
Avoid empty catch blocks	204 - 205
Avoid empty catch blocks	215 - 216
Avoid empty catch blocks	220 - 221
Avoid empty catch blocks	230 - 231
Avoid empty catch blocks	234 - 235
Avoid empty catch blocks	248 - 249

openr66/context/task/ExecOutputTask.java

Violation	Line
These nested if statements could be combined	114 - 121
Avoid empty catch blocks	135 - 136
Avoid empty catch blocks	181 - 182
Avoid empty catch blocks	185 - 186
Avoid empty catch blocks	190 - 191
Avoid empty catch blocks	211 - 212
Avoid empty catch blocks	216 - 217
Avoid empty catch blocks	226 - 227
Avoid empty catch blocks	230 - 231
Avoid empty catch blocks	244 - 245
Avoid empty catch blocks	312 - 313
Avoid empty catch blocks	320 - 321
Avoid empty catch blocks	325 - 326

openr66/context/task/ExecTask.java

Violation	Line
These nested if statements could be combined	98 - 105

openr66/context/task/LastLineReader.java

Violation	Line
Avoid empty catch blocks	60 - 64
Avoid empty catch blocks	67 - 68

openr66/context/task/localexec/LocalExecClient.java

Violation	Line
Document empty constructor	88 - 90

openr66/context/task/LogTask.java

Violation	Line
Avoid empty catch blocks	109 - 110
Avoid empty catch blocks	119 - 120

openr66/context/task/RescheduleTransferTask.java

Violation	Line
Deeply nested if..then statements are hard to read	199 - 202
Avoid if (x != y) ..; else ..;	228 - 232
Avoid if (x != y) ..; else ..;	236 - 240
Avoid if (x != y) ..; else ..;	253 - 263
These nested if statements could be combined	259 - 262
Avoid if (x != y) ..; else ..;	271 - 275
Avoid if (x != y) ..; else ..;	279 - 283
Avoid if (x != y) ..; else ..;	296 - 306
These nested if statements could be combined	302 - 305
Switch statements should have a default label	362 - 411

openr66/context/task/TaskType.java

Violation	Line
New exception is thrown in catch block, original stack trace may be lost	139
New exception is thrown in catch block, original stack trace may be lost	142

openr66/context/task/TransferTask.java

Violation	Line
When instantiating a SimpleDateFormat object, specify a Locale	122
Avoid empty catch blocks	127 - 128
Avoid if (x != y) ..; else ..;	155 - 170

openr66/database/data/DbConfiguration.java

Violation	Line
Overridable method 'setToArray' called during object construction	234
Overridable method 'select' called during object construction	247
Consider simply returning the value vs storing it in local variable 'prep'	372

openr66/database/data/DbHostAuth.java

Violation	Line
Overridable method 'setToArray' called during object construction	225
Overridable method 'select' called during object construction	238
Consider simply returning the value vs storing it in local variable 'prep'	475
Avoid if (x != y) ..; else ..;	497 - 501
Avoid if (x != y) ..; else ..;	504 - 508
Do not hard code IPv4 or IPv6 addresses, even 127.0.0.1 !	583
Do not hard code IPv4 or IPv6 addresses, even 127.0.0.1 !	590
Avoid if (x != y) ..; else ..;	631

openr66/database/data/DbMultipleMonitor.java

Violation	Line
Overridable method 'setToArray' called during object construction	193
Overridable method 'select' called during object construction	206
Consider simply returning the value vs storing it in local variable 'prep'	323
Document empty method	376 - 377

openr66/database/data/DbRule.java

Violation	Line
Overridable method 'setToArray' called during object construction	492
Overridable method 'select' called during object construction	505
Overridable method 'setToArray' called during object construction	560
These nested if statements could be combined	666 - 668
Consider simply returning the value vs storing it in local variable 'prep'	760
Avoid if (x != y) ..; else ..;	1060 - 1064

openr66/database/data/DbTaskRunner.java

Violation	Line
Avoid if (x != y) ..; else ..;	506 - 510
Overridable method 'setToArray' called during object construction	511
Overridable method 'checkThroughMode' called during object construction	524
Overridable method 'create' called during object construction	525
Overridable method 'setToArray' called during object construction	561
Overridable method 'checkThroughMode' called during object construction	574
Overridable method 'insert' called during object construction	575
Overridable method 'select' called during object construction	607
These nested if statements could be combined	609 - 612
Overridable method 'select' called during object construction	638
Document empty method	665 - 666
Avoid empty catch blocks	691 - 692
Avoid empty catch blocks	722 - 724
Avoid empty catch blocks	760 - 762
New exception is thrown in catch block, original stack trace may be lost	806
New exception is thrown in catch block, original stack trace may be lost	815
New exception is thrown in catch block, original stack trace may be lost	818
New exception is thrown in catch block, original stack trace may be lost	859
Avoid empty catch blocks	893 - 895
These nested if statements could be combined	905 - 908
Avoid if (x != y) ..; else ..;	1002 - 1007
Avoid if (x != y) ..; else ..;	1026 - 1038
Avoid if (x != y) ..; else ..;	1094 - 1102
Avoid if (x != y) ..; else ..;	1224 - 1232
Consider simply returning the value vs storing it in local variable 'pstt'	1320
Avoid empty catch blocks	1357 - 1358
Avoid empty catch blocks	1358 - 1359
Avoid empty catch blocks	1359 - 1360
Avoid if (x != y) ..; else ..;	1378 - 1384
Avoid empty catch blocks	1422 - 1423
Avoid empty catch blocks	1423 - 1424
Avoid empty catch blocks	1424 - 1425
Avoid if (x != y) ..; else ..;	1442 - 1447
Avoid if (x != y) ..; else ..;	1477 - 1481
Avoid if (x != y) ..; else ..;	1514 - 1518
Avoid empty catch blocks	1540 - 1541
Avoid empty catch blocks	1541 - 1542
Avoid empty catch blocks	1542 - 1543
Avoid if (x != y) ..; else ..;	1599 - 1625
Avoid if (x != y) ..; else ..;	1610 - 1625
Avoid if (x != y) ..; else ..;	1660 - 1680
Avoid if (x != y) ..; else ..;	1669 - 1680
Avoid if (x != y) ..; else ..;	1830 - 1856
Switch statements should have a default label	1832 - 1849
These nested if statements could be combined	1888 - 1890
Avoid empty catch blocks	1915 - 1916
Avoid if (x != y) ..; else ..;	1928 - 1944
Avoid empty if statements	1942 - 1944
Avoid empty catch blocks	1945 - 1946
Use equals() to compare object references.	1965
These nested if statements could be combined	2141 - 2146
Avoid empty catch blocks	2144 - 2145
These nested if statements could be combined	2330 - 2331
A switch statement does not contain a break	2429 - 2468
Avoid if (x != y) ..; else ..;	2509 - 2513
Avoid if (x != y) ..; else ..;	2520 - 2526
These nested if statements could be combined	2560 - 2593
Avoid empty catch blocks	2591 - 2592
Avoid empty if statements	2597 - 2599
Avoid if (x != y) ..; else ..;	2640
Avoid if (x != y) ..; else ..;	2664 - 2668
Avoid empty catch blocks	2703 - 2705
Document empty method	2772 - 2774
Avoid if (x != y) ..; else ..;	2796
Avoid if (x != y) ..; else ..;	2866 - 2867
Avoid empty catch blocks	2868 - 2869
These nested if statements could be combined	2874 - 2900
Avoid if (x != y) ..; else ..;	2984
Avoid if (x != y) ..; else ..;	3031 - 3032
When doing a String.toLowerCase()/toUpperCase() call, use a Locale	3152
When doing a String.toLowerCase()/toUpperCase() call, use a Locale	3170
New exception is thrown in catch block, original stack trace may be lost	3209
New exception is thrown in catch block, original stack trace may be lost	3238
New exception is thrown in catch block, original stack trace may be lost	3241
Avoid if (x != y) ..; else ..;	3243 - 3274
Avoid empty catch blocks	3251 - 3252
New exception is thrown in catch block, original stack trace may be lost	3256
Avoid empty catch blocks	3260 - 3261
New exception is thrown in catch block, original stack trace may be lost	3265
Avoid empty catch blocks	3270 - 3271
New exception is thrown in catch block, original stack trace may be lost	3338
New exception is thrown in catch block, original stack trace may be lost	3341
New exception is thrown in catch block, original stack trace may be lost	3345
New exception is thrown in catch block, original stack trace may be lost	3348
Avoid if (x != y) ..; else ..;	3350 - 3381
Avoid empty catch blocks	3358 - 3359
New exception is thrown in catch block, original stack trace may be lost	3363
Avoid empty catch blocks	3367 - 3368
New exception is thrown in catch block, original stack trace may be lost	3372
Avoid empty catch blocks	3377 - 3378
New exception is thrown in catch block, original stack trace may be lost	3400
New exception is thrown in catch block, original stack trace may be lost	3406

openr66/database/model/DbModelFactory.java

Violation	Line
All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning.	34 - 69

openr66/database/model/DbModelMysql.java

Violation	Line
Use block level rather than method level synchronization	297 - 345
Avoid empty catch blocks	309 - 310
Avoid empty catch blocks	341 - 342

openr66/protocol/configuration/Configuration.java

Violation	Line
This final field could be made static	210
This final field could be made static	215
Private field 'timerCloseOperations' could be made final; it is only initialized in the declaration or constructor.	447
Private field 'timerTrafficCounter' could be made final; it is only initialized in the declaration or constructor.	453
Overridable method 'computeNbThreads' called during object construction	540
Avoid if (x != y) ..; else ..;	744 - 749
Avoid empty catch blocks	813 - 814
Avoid empty catch blocks	814 - 815

openr66/protocol/exception/OpenR66ExceptionTrappedFactory.java

Violation	Line
All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning.	46 - 168

openr66/protocol/exception/OpenR66ProtocolNoDataException.java

Violation	Line
Document empty constructor	38 - 39

openr66/protocol/http/adminssl/HttpSslHandler.java

Violation	Line
Perhaps 'queryStringDecoder' could be replaced by a local variable.	132
Avoid if (x != y) ..; else ..;	376 - 460
Avoid if (x != y) ..; else ..;	433
Avoid if (x != y) ..; else ..;	480 - 750
Avoid if (x != y) ..; else ..;	537
Avoid if (x != y) ..; else ..;	619
Avoid if (x != y) ..; else ..;	638 - 642
Avoid empty catch blocks	660 - 661
Avoid if (x != y) ..; else ..;	672 - 693
Avoid empty catch blocks	681 - 682
These nested if statements could be combined	689 - 691
Avoid if (x != y) ..; else ..;	697
Avoid if (x != y) ..; else ..;	728
Avoid empty catch blocks	798 - 800
Avoid empty catch blocks	845 - 846
Avoid empty catch blocks	846 - 847
Avoid if (x != y) ..; else ..;	874 - 1078
Switch statements should have a default label	1110 - 1135
Avoid if (x != y) ..; else ..;	1158 - 1375
Position literals first in String comparisons	1184
Position literals first in String comparisons	1187
Position literals first in String comparisons	1190
Position literals first in String comparisons	1193
Position literals first in String comparisons	1196
Position literals first in String comparisons	1199
Position literals first in String comparisons	1202
Position literals first in String comparisons	1205
Position literals first in String comparisons	1235
Position literals first in String comparisons	1237
Position literals first in String comparisons	1239
Avoid empty catch blocks	1410 - 1411
Avoid empty catch blocks	1411 - 1412
Avoid empty catch blocks	1412 - 1413
Avoid empty catch blocks	1421 - 1422
Avoid empty catch blocks	1422 - 1423
Avoid empty catch blocks	1423 - 1424
Avoid if (x != y) ..; else ..;	1552 - 1583
Avoid if (x != y) ..; else ..;	1568 - 1577
Avoid if (x != y) ..; else ..;	1719 - 1731
Avoid if (x != y) ..; else ..;	1735 - 1772
These nested if statements could be combined	1760 - 1764
Avoid if (x != y) ..; else ..;	1839 - 1853
Avoid if (x != y) ..; else ..;	1866 - 1887

openr66/protocol/http/HttpFormattedHandler.java

Violation	Line
Perhaps 'uriRequest' could be replaced by a local variable.	150
Avoid if (x != y) ..; else ..;	281 - 286
These nested if statements could be combined	296 - 297
Avoid if (x != y) ..; else ..;	362
Avoid if (x != y) ..; else ..;	673 - 696

openr66/protocol/http/HttpWriteCacheEnable.java

Violation	Line
All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning.	50 - 132
Avoid empty if statements	121 - 122

openr66/protocol/localhandler/LocalChannelReference.java

Violation	Line
Private field 'futureValidRequest' could be made final; it is only initialized in the declaration or constructor.	102
Avoid if (x != y) ..; else ..;	356 - 372
Avoid if (x != y) ..; else ..;	400 - 409
Avoid if (x != y) ..; else ..;	471 - 475
Avoid if (x != y) ..; else ..;	479 - 483
Avoid if (x != y) ..; else ..;	487 - 503
Avoid if (x != y) ..; else ..;	488 - 499
Avoid if (x != y) ..; else ..;	491 - 495
These nested if statements could be combined	507 - 509
Avoid if (x != y) ..; else ..;	530 - 544
Avoid if (x != y) ..; else ..;	550
Avoid if (x != y) ..; else ..;	551
Avoid if (x != y) ..; else ..;	552
Avoid if (x != y) ..; else ..;	553
Avoid if (x != y) ..; else ..;	554

openr66/protocol/localhandler/LocalClientHandler.java

Violation	Line
Avoid if (x != y) ..; else ..;	164 - 192

openr66/protocol/localhandler/LocalServerHandler.java

Violation	Line
Avoid if (x != y) ..; else ..;	146 - 147
Avoid if (x != y) ..; else ..;	147 - 148
Avoid empty if statements	153 - 155
These nested if statements could be combined	163 - 169
Deeply nested if..then statements are hard to read	163 - 169
These nested if statements could be combined	165 - 168
Avoid empty catch blocks	179 - 180
These nested if statements could be combined	185 - 196
Avoid if (x != y) ..; else ..;	191
Avoid if (x != y) ..; else ..;	194
Avoid if (x != y) ..; else ..;	202 - 228
Avoid if (x != y) ..; else ..;	414 - 578
Avoid empty catch blocks	425 - 426
Avoid empty catch blocks	426 - 427
These nested if statements could be combined	448 - 454
Avoid empty catch blocks	479 - 480
Avoid empty catch blocks	480 - 481
Avoid empty catch blocks	504 - 505
Avoid if (x != y) ..; else ..;	515 - 528
A switch statement does not contain a break	516 - 525
Avoid empty catch blocks	542 - 544
Avoid if (x != y) ..; else ..;	606 - 610
Avoid if (x != y) ..; else ..;	732 - 733
Private field 'localChannelReference' could be made final; it is only initialized in the declaration or constructor.	766
Private field 'result' could be made final; it is only initialized in the declaration or constructor.	767
Avoid empty catch blocks	819 - 820
Avoid empty catch blocks	842 - 843
Avoid if (x != y) ..; else ..;	897
Avoid if (x != y) ..; else ..;	897
Avoid reassigning parameters such as 'packet'	941
Avoid if (x != y) ..; else ..;	1012 - 1120
Avoid empty catch blocks	1049 - 1050
Avoid empty catch blocks	1079 - 1080
Avoid empty catch blocks	1165 - 1166
Avoid empty catch blocks	1166 - 1167
Avoid empty catch blocks	1271 - 1272
Avoid empty catch blocks	1272 - 1273
Avoid empty catch blocks	1299 - 1300
Avoid empty catch blocks	1300 - 1301
Avoid empty catch blocks	1321 - 1322
Avoid empty catch blocks	1322 - 1323
These nested if statements could be combined	1335 - 1354
Avoid empty catch blocks	1344 - 1345
Avoid empty catch blocks	1345 - 1346
Avoid empty catch blocks	1370 - 1371
Avoid empty catch blocks	1371 - 1372
Avoid if (x != y) ..; else ..;	1431 - 1452
Avoid empty catch blocks	1442 - 1444
Avoid empty catch blocks	1572 - 1573
A high ratio of statements to labels in a switch statement. Consider refactoring.	1595 - 2158
Avoid empty catch blocks	1613 - 1615
Avoid if (x != y) ..; else ..;	1617 - 1632
Avoid empty catch blocks	1623 - 1624
Avoid empty catch blocks	1628 - 1629
Avoid if (x != y) ..; else ..;	1674 - 1705
Avoid empty catch blocks	1689 - 1690
Avoid empty catch blocks	1714 - 1715
Avoid empty catch blocks	1810 - 1811
Avoid empty catch blocks	1878 - 1879
Avoid empty catch blocks	1903 - 1905
These nested if statements could be combined	1917 - 1927
Avoid empty catch blocks	1923 - 1925
Avoid empty catch blocks	1936 - 1938
These nested if statements could be combined	1963 - 1973
Avoid empty catch blocks	1969 - 1971
Avoid empty catch blocks	1989 - 1990
Avoid empty catch blocks	2023 - 2024
Avoid empty catch blocks	2058 - 2059
Avoid empty catch blocks	2083 - 2084
Avoid empty catch blocks	2090 - 2091
Avoid empty catch blocks	2091 - 2092
Avoid empty catch blocks	2141 - 2142
Avoid empty catch blocks	2178 - 2180
Avoid empty catch blocks	2220 - 2221

openr66/protocol/localhandler/LocalTransaction.java

Violation	Line
These nested if statements could be combined	304 - 307
Avoid empty catch blocks	375 - 376
Avoid empty catch blocks	376 - 377
Avoid if (x != y) ..; else ..;	444 - 445
Avoid empty catch blocks	476 - 477
Avoid empty catch blocks	484 - 485
Avoid empty catch blocks	499 - 500
Avoid empty catch blocks	500 - 501
Avoid empty catch blocks	508 - 509

openr66/protocol/localhandler/Monitoring.java

Violation	Line
Private field 'startMonitor' could be made final; it is only initialized in the declaration or constructor.	73
Private field 'pastLimit' could be made final; it is only initialized in the declaration or constructor.	74
Private field 'minimalDelay' could be made final; it is only initialized in the declaration or constructor.	76
Private field 'trafficCounter' could be made final; it is only initialized in the declaration or constructor.	79
Avoid if (x != y) ..; else ..;	183 - 187
Overridable method 'initialize' called during object construction	188
Avoid empty catch blocks	245 - 246
Avoid empty catch blocks	246 - 247
Avoid empty catch blocks	288 - 289
Avoid empty catch blocks	496 - 497
Avoid empty catch blocks	497 - 498
Switch statements should have a default label	736 - 749
Switch statements should have a default label	785 - 874
Switch statements should have a default label	879 - 992
Avoid empty catch blocks	993 - 994
Avoid empty catch blocks	994 - 995
Switch statements should have a default label	1007 - 1048
Switch statements should have a default label	1053 - 1119
Avoid empty catch blocks	1124 - 1125
Avoid empty catch blocks	1130 - 1131
Switch statements should have a default label	1147 - 1268

openr66/protocol/localhandler/packet/AbstractLocalPacket.java

Violation	Line
Avoid if (x != y) ..; else ..;	91 - 92
Avoid if (x != y) ..; else ..;	97 - 98
Avoid if (x != y) ..; else ..;	103 - 104

openr66/protocol/localhandler/packet/BusinessRequestPacket.java

Violation	Line
Private field 'sheader' could be made final; it is only initialized in the declaration or constructor.	44

openr66/protocol/localhandler/packet/EndRequestPacket.java

Violation	Line
Avoid if (x != y) ..; else ..;	156

openr66/protocol/localhandler/packet/InformationPacket.java

Violation	Line
Avoid if (x != y) ..; else ..;	161 - 165

openr66/protocol/localhandler/packet/LocalPacketFactory.java

Violation	Line
All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning.	32 - 155
A switch statement does not contain a break	94 - 153

openr66/protocol/localhandler/packet/LocalPacketSizeEstimator.java

Violation	Line
Private field 'internal' could be made final; it is only initialized in the declaration or constructor.	33

openr66/protocol/localhandler/packet/RequestPacket.java

Violation	Line
Switch statements should have a default label	72 - 78
A switch statement does not contain a break	72 - 78

openr66/protocol/localhandler/RetrieveRunner.java

Violation	Line
Avoid empty catch blocks	146 - 147
Avoid empty catch blocks	154 - 156
These nested if statements could be combined	166 - 175
Avoid empty catch blocks	173 - 174
Avoid empty catch blocks	202 - 203
Avoid empty catch blocks	208 - 210
Avoid empty catch blocks	225 - 226
Avoid empty catch blocks	250 - 251

openr66/protocol/networkhandler/ChannelTrafficHandler.java

Violation	Line
Do not use if statements that are always true or always false	61

openr66/protocol/networkhandler/GlobalTrafficHandler.java

Violation	Line
Do not use if statements that are always true or always false	63

openr66/protocol/networkhandler/NetworkChannel.java

Violation	Line
Use block level rather than method level synchronization	65 - 72
Use block level rather than method level synchronization	74 - 79
Use block level rather than method level synchronization	81 - 89

openr66/protocol/networkhandler/NetworkServerHandler.java

Violation	Line
Perhaps 'networkChannel' could be replaced by a local variable.	76
Avoid empty catch blocks	235 - 236
Avoid if (x != y) ..; else ..;	355 - 384
Avoid empty catch blocks	399 - 400

openr66/protocol/networkhandler/NetworkServerPipelineFactory.java

Violation	Line
Private field 'server' could be made final; it is only initialized in the declaration or constructor.	53
Avoid empty catch blocks	74 - 75

openr66/protocol/networkhandler/NetworkTransaction.java

Violation	Line
These nested if statements could be combined	290 - 292
Avoid if (x != y) ..; else ..;	345 - 349
These nested if statements could be combined	360 - 365
Avoid empty catch blocks	474 - 475
Avoid empty catch blocks	496 - 497
Avoid empty catch blocks	517 - 518
New exception is thrown in catch block, original stack trace may be lost	608 - 609
Avoid if (x != y) ..; else ..;	658 - 665
Avoid if (x != y) ..; else ..;	785 - 797
Private field 'networkChannel' could be made final; it is only initialized in the declaration or constructor.	816
Private field 'requester' could be made final; it is only initialized in the declaration or constructor.	817
Private field 'address' could be made final; it is only initialized in the declaration or constructor.	818
Avoid if (x != y) ..; else ..;	881 - 903
Avoid empty catch blocks	893 - 894

openr66/protocol/networkhandler/packet/NetworkPacketSizeEstimator.java

Violation	Line
Private field 'internal' could be made final; it is only initialized in the declaration or constructor.	33
Consider simply returning the value vs storing it in local variable 'size'	48

openr66/protocol/networkhandler/R66ConstraintLimitHandler.java

Violation	Line
Avoid if (x != y) ..; else ..;	70 - 71

openr66/protocol/networkhandler/ssl/NetworkSslServerHandler.java

Violation	Line
Avoid if (x != y) ..; else ..;	155 - 180
Avoid if (x != y) ..; else ..;	168 - 169

openr66/protocol/networkhandler/ssl/NetworkSslServerPipelineFactory.java

Violation	Line
Avoid empty catch blocks	97 - 98

openr66/protocol/snmp/R66Counter32.java

Violation	Line
Private field 'type' could be made final; it is only initialized in the declaration or constructor.	35
Private field 'entry' could be made final; it is only initialized in the declaration or constructor.	36
Overridable method 'setInternalValue' called during object construction	44
Overridable method 'setInternalValue' called during object construction	49

openr66/protocol/snmp/R66Gauge32.java

Violation	Line
Private field 'type' could be made final; it is only initialized in the declaration or constructor.	35
Private field 'entry' could be made final; it is only initialized in the declaration or constructor.	36
Overridable method 'setInternalValue' called during object construction	44
Overridable method 'setInternalValue' called during object construction	49

openr66/protocol/snmp/R66PrivateMib.java

Violation	Line
Document empty method	322 - 323
Document empty method	329 - 330

openr66/protocol/snmp/R66TimeTicks.java

Violation	Line
Private field 'type' could be made final; it is only initialized in the declaration or constructor.	35
Private field 'entry' could be made final; it is only initialized in the declaration or constructor.	36
Overridable method 'setInternalValue' called during object construction	44
Overridable method 'setInternalValue' called during object construction	49

openr66/protocol/test/TestBusinessRequest.java

Violation	Line
All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning.	45 - 108
Singleton is not thread safe	59 - 61

openr66/protocol/test/TestExecJavaTask.java

Violation	Line
Avoid empty catch blocks	62 - 63

openr66/protocol/test/TestProgressBarTransfer.java

Violation	Line
Avoid if (x != y) ..; else ..;	123
Avoid if (x != y) ..; else ..;	129

openr66/protocol/test/TestRecvThroughClient.java

Violation	Line
All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning.	44 - 145
Avoid if (x != y) ..; else ..;	113
Avoid if (x != y) ..; else ..;	118

openr66/protocol/test/TestSendThroughClient.java

Violation	Line
Avoid if (x != y) ..; else ..;	183
Avoid if (x != y) ..; else ..;	188

openr66/protocol/test/TestSendThroughForward.java

Violation	Line
These nested if statements could be combined	251 - 257
Avoid empty catch blocks	255 - 256
Overriding method merely calls super	277 - 279

openr66/protocol/test/TestSubmitTransfer.java

Violation	Line
All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning.	42 - 114
Avoid empty if statements	54 - 55

openr66/protocol/test/TestTransaction.java

Violation	Line
Possible unsafe assignment to a non-final static field in a constructor.	58
Singleton is not thread safe	122 - 124

openr66/protocol/test/TestTransferNoDb.java

Violation	Line
All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning.	46 - 151
Avoid empty if statements	58 - 59
Avoid if (x != y) ..; else ..;	134
Avoid if (x != y) ..; else ..;	136
Avoid empty catch blocks	137 - 138

openr66/protocol/utils/ChannelCloseTimer.java

Violation	Line
Private field 'channel' could be made final; it is only initialized in the declaration or constructor.	39

openr66/protocol/utils/ChannelUtils.java

Violation	Line
Deeply nested if..then statements are hard to read	339 - 341

openr66/protocol/utils/FileUtils.java

Violation	Line
All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning.	46 - 523
Avoid empty catch blocks	109 - 110
Avoid empty catch blocks	187 - 188
Avoid empty catch blocks	385 - 386
Avoid empty catch blocks	478 - 479
Avoid empty catch blocks	486 - 487
Avoid empty catch blocks	506 - 507
Avoid empty catch blocks	514 - 515

openr66/protocol/utils/OpenR66SignalHandler.java

Violation	Line
A switch with less than 3 branches is inefficient, use a if statement instead.	132 - 144
When doing a String.toLowerCase()/toUpperCase() call, use a Locale	202
Avoid empty catch blocks	224 - 225

openr66/protocol/utils/R66Future.java

Violation	Line
Document empty constructor	44 - 45
Avoid if (x != y) ..; else ..;	72
Avoid if (x != y) ..; else ..;	73

openr66/protocol/utils/TransferUtils.java

Violation	Line
All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning.	55 - 311
Avoid if (x != y) ..; else ..;	70 - 145
Do not use if statements that are always true or always false	76
These nested if statements could be combined	76 - 80
Avoid if (x != y) ..; else ..;	156 - 182
Avoid empty catch blocks	165 - 166
These nested if statements could be combined	177 - 179
Avoid if (x != y) ..; else ..;	187
Avoid empty catch blocks	289 - 290
Avoid empty catch blocks	306 - 307

openr66/server/ChangeBandwidthLimits.java

Violation	Line
Singleton is not thread safe	177 - 179
Avoid if (x != y) ..; else ..;	204 - 205
Avoid if (x != y) ..; else ..;	209 - 210

openr66/server/ConfigExport.java

Violation	Line
Singleton is not thread safe	152 - 154
Avoid if (x != y) ..; else ..;	179 - 180
Avoid if (x != y) ..; else ..;	184 - 185

openr66/server/ConfigImport.java

Violation	Line
Singleton is not thread safe	176 - 178
Avoid if (x != y) ..; else ..;	203 - 204
Avoid if (x != y) ..; else ..;	208 - 209

openr66/server/LogExport.java

Violation	Line
Avoid if (x != y) ..; else ..;	92
Avoid if (x != y) ..; else ..;	93
When instantiating a SimpleDateFormat object, specify a Locale	148
Static DateFormatter objects should be accessed in a synchronized manner	158
Static DateFormatter objects should be accessed in a synchronized manner	175
Deeply nested if..then statements are hard to read	178 - 180
Singleton is not thread safe	254 - 256
Avoid if (x != y) ..; else ..;	281 - 282
Avoid if (x != y) ..; else ..;	286 - 287

openr66/server/R66Server.java

Violation	Line
All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning.	39 - 72

openr66/server/ServerExportConfiguration.java

Violation	Line
All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning.	49 - 153
Singleton is not thread safe	61 - 63

openr66/server/ServerInitDatabase.java

Violation	Line
All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning.	48 - 180
Singleton is not thread safe	94 - 96
These nested if statements could be combined	143 - 145
These nested if statements could be combined	149 - 152

openr66/server/ServerShutdown.java

Violation	Line
All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning.	52 - 118

GoldenGate OpenR66

Project Documentation

PMD Results

Files

openr66/client/AbstractBusinessRequest.java

openr66/client/AbstractTransfer.java

openr66/client/DirectTransfer.java

openr66/client/Message.java

openr66/client/ProgressBarTransfer.java

openr66/client/RecvThroughClient.java

openr66/client/RequestInformation.java

openr66/client/RequestTransfer.java

openr66/client/SendThroughClient.java

openr66/client/SubmitTransfer.java

openr66/commander/ClientRunner.java

openr66/commander/Commander.java

openr66/commander/InternalRunner.java

openr66/configuration/AuthenticationFileBasedConfiguration.java

openr66/configuration/FileBasedConfiguration.java

openr66/configuration/RuleFileBasedConfiguration.java

openr66/context/authentication/R66Auth.java

openr66/context/filesystem/R66Dir.java

openr66/context/filesystem/R66File.java

openr66/context/filesystem/R66Restart.java

openr66/context/R66DefaultBusinessFactory.java

openr66/context/R66Result.java

openr66/context/R66Session.java

openr66/context/task/AbstractExecJavaTask.java

openr66/context/task/AbstractTask.java

openr66/context/task/AllLineReader.java

openr66/context/task/ExecJavaTask.java

openr66/context/task/ExecMoveTask.java

openr66/context/task/ExecOutputTask.java

openr66/context/task/ExecTask.java

openr66/context/task/LastLineReader.java

openr66/context/task/localexec/LocalExecClient.java

openr66/context/task/LogTask.java

openr66/context/task/RescheduleTransferTask.java

openr66/context/task/TaskType.java

openr66/context/task/TransferTask.java

openr66/database/data/DbConfiguration.java

openr66/database/data/DbHostAuth.java

openr66/database/data/DbMultipleMonitor.java

openr66/database/data/DbRule.java

openr66/database/data/DbTaskRunner.java

openr66/database/model/DbModelFactory.java

openr66/database/model/DbModelMysql.java

openr66/protocol/configuration/Configuration.java

openr66/protocol/exception/OpenR66ExceptionTrappedFactory.java

openr66/protocol/exception/OpenR66ProtocolNoDataException.java

openr66/protocol/http/adminssl/HttpSslHandler.java

openr66/protocol/http/HttpFormattedHandler.java

openr66/protocol/http/HttpWriteCacheEnable.java

openr66/protocol/localhandler/LocalChannelReference.java

openr66/protocol/localhandler/LocalClientHandler.java

openr66/protocol/localhandler/LocalServerHandler.java

openr66/protocol/localhandler/LocalTransaction.java

openr66/protocol/localhandler/Monitoring.java

openr66/protocol/localhandler/packet/AbstractLocalPacket.java

openr66/protocol/localhandler/packet/BusinessRequestPacket.java

openr66/protocol/localhandler/packet/EndRequestPacket.java

openr66/protocol/localhandler/packet/InformationPacket.java

openr66/protocol/localhandler/packet/LocalPacketFactory.java

openr66/protocol/localhandler/packet/LocalPacketSizeEstimator.java

openr66/protocol/localhandler/packet/RequestPacket.java

openr66/protocol/localhandler/RetrieveRunner.java

openr66/protocol/networkhandler/ChannelTrafficHandler.java

openr66/protocol/networkhandler/GlobalTrafficHandler.java

openr66/protocol/networkhandler/NetworkChannel.java

openr66/protocol/networkhandler/NetworkServerHandler.java

openr66/protocol/networkhandler/NetworkServerPipelineFactory.java

openr66/protocol/networkhandler/NetworkTransaction.java

openr66/protocol/networkhandler/packet/NetworkPacketSizeEstimator.java

openr66/protocol/networkhandler/R66ConstraintLimitHandler.java

openr66/protocol/networkhandler/ssl/NetworkSslServerHandler.java

openr66/protocol/networkhandler/ssl/NetworkSslServerPipelineFactory.java

openr66/protocol/snmp/R66Counter32.java

openr66/protocol/snmp/R66Gauge32.java

openr66/protocol/snmp/R66PrivateMib.java

openr66/protocol/snmp/R66TimeTicks.java