PMD Results

The following document contains the results of PMD 4.3.

Files

goldengate/ftp/exec/adminssl/HttpSslHandler.java

ViolationLine
Perhaps 'queryStringDecoder' could be replaced by a local variable.116
Avoid if (x != y) ..; else ..;336 - 340
Avoid if (x != y) ..; else ..;406 - 410
Avoid if (x != y) ..; else ..;540 - 552
Avoid if (x != y) ..; else ..;545 - 550
Avoid if (x != y) ..; else ..;555 - 559
Avoid if (x != y) ..; else ..;620 - 651
Avoid if (x != y) ..; else ..;636 - 645
Avoid if (x != y) ..; else ..;775 - 786
Avoid if (x != y) ..; else ..;790 - 828
These nested if statements could be combined815 - 820
Avoid if (x != y) ..; else ..;926 - 947

goldengate/ftp/exec/config/AUTHUPDATE.java

ViolationLine
Avoid if (x != y) ..; else ..;62 - 82
These nested if statements could be combined87 - 91

goldengate/ftp/exec/config/FileBasedConfiguration.java

ViolationLine
Perhaps 'httpsBootstrap' could be replaced by a local variable.597
Avoid if (x != y) ..; else ..;646 - 651
Avoid if (x != y) ..; else ..;658 - 666
Avoid if (x != y) ..; else ..;682 - 698
Avoid if (x != y) ..; else ..;701 - 705
Avoid if (x != y) ..; else ..;710 - 715
These nested if statements could be combined717 - 720
Avoid if (x != y) ..; else ..;724 - 729
Avoid if (x != y) ..; else ..;811 - 826
Avoid if (x != y) ..; else ..;956 - 978
Avoid if (x != y) ..; else ..;999 - 1003
Avoid if (x != y) ..; else ..;1339 - 1353
Avoid if (x != y) ..; else ..;1381 - 1414
Avoid if (x != y) ..; else ..;1397 - 1413
Avoid if (x != y) ..; else ..;1523 - 1526
Avoid if (x != y) ..; else ..;1527 - 1530
Avoid if (x != y) ..; else ..;1534 - 1544

goldengate/ftp/exec/control/ExecBusinessHandler.java

ViolationLine
New exception is thrown in catch block, original stack trace may be lost135
New exception is thrown in catch block, original stack trace may be lost165
Avoid if (x != y) ..; else ..;189 - 190
Avoid empty if statements248 - 250
Avoid if (x != y) ..; else ..;248 - 267
Avoid empty if statements250 - 252
These nested if statements could be combined255 - 266
These nested if statements could be combined256 - 265
Deeply nested if..then statements are hard to read259 - 263
Avoid if (x != y) ..; else ..;322 - 324
Avoid if (x != y) ..; else ..;336 - 338
Document empty method350 - 351
Avoid if (x != y) ..; else ..;357 - 365
Avoid if (x != y) ..; else ..;360 - 364
These nested if statements could be combined370 - 373
These nested if statements could be combined381 - 384
When doing a String.toLowerCase()/toUpperCase() call, use a Locale498
Position literals first in String comparisons499

goldengate/ftp/exec/control/GoldenGateActionLogger.java

ViolationLine
All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning.45 - 226
Deeply nested if..then statements are hard to read82 - 86
Avoid empty catch blocks89 - 91
Avoid if (x != y) ..; else ..;111 - 140
Avoid empty catch blocks126 - 128
Avoid if (x != y) ..; else ..;160 - 224
Avoid if (x != y) ..; else ..;164 - 172
Avoid empty catch blocks167 - 168
Avoid empty catch blocks168 - 169
Avoid empty catch blocks196 - 198
These nested if statements could be combined206 - 209
These nested if statements could be combined219 - 222

goldengate/ftp/exec/data/FileSystemBasedDataBusinessHandler.java

ViolationLine
Document empty method43 - 44
Document empty method54 - 55
Document empty method65 - 66
Document empty method76 - 77

goldengate/ftp/exec/database/data/DbTransferLog.java

ViolationLine
Overridable method 'setToArray' called during object construction186
Overridable method 'insert' called during object construction188
New exception is thrown in catch block, original stack trace may be lost456
New exception is thrown in catch block, original stack trace may be lost465
New exception is thrown in catch block, original stack trace may be lost468
Avoid if (x != y) ..; else ..;520 - 525
Avoid if (x != y) ..; else ..;558 - 584
Avoid if (x != y) ..; else ..;569 - 584
Avoid empty catch blocks621 - 622
Avoid empty catch blocks622 - 623
Avoid empty catch blocks623 - 624
Avoid empty catch blocks678 - 679
Avoid empty catch blocks679 - 680
Avoid empty catch blocks680 - 681
Avoid empty catch blocks698 - 699
Avoid empty catch blocks699 - 700
Avoid empty catch blocks700 - 701
Use equals() to compare object references.807
Document empty method905 - 907

goldengate/ftp/exec/database/model/DbModelFactory.java

ViolationLine
All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning.34 - 69

goldengate/ftp/exec/database/model/DbModelMysql.java

ViolationLine
Use block level rather than method level synchronization187 - 235
Avoid empty catch blocks199 - 200
Avoid empty catch blocks231 - 232

goldengate/ftp/exec/exec/AbstractExecutor.java

ViolationLine
Possible unsafe assignment to a non-final static field in a constructor.74
Avoid empty while statements348 - 349

goldengate/ftp/exec/exec/ExecuteExecutor.java

ViolationLine
These nested if statements could be combined90 - 93
New exception is thrown in catch block, original stack trace may be lost126
New exception is thrown in catch block, original stack trace may be lost126
New exception is thrown in catch block, original stack trace may be lost131
New exception is thrown in catch block, original stack trace may be lost131
New exception is thrown in catch block, original stack trace may be lost139
New exception is thrown in catch block, original stack trace may be lost145

goldengate/ftp/exec/exec/LocalExecClient.java

ViolationLine
Document empty constructor95 - 97

goldengate/ftp/exec/exec/R66PreparedTransferExecutor.java

ViolationLine
When instantiating a SimpleDateFormat object, specify a Locale138
Avoid empty catch blocks143 - 144
New exception is thrown in catch block, original stack trace may be lost184 - 185
New exception is thrown in catch block, original stack trace may be lost203
New exception is thrown in catch block, original stack trace may be lost211

goldengate/ftp/exec/ExecGatewayFtpServer.java

ViolationLine
All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning.48 - 112

goldengate/ftp/exec/file/FileBasedAuth.java

ViolationLine
Avoid empty catch blocks203 - 204

goldengate/ftp/exec/ServerInitDatabase.java

ViolationLine
All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning.42 - 122
Singleton is not thread safe73 - 75

goldengate/ftp/exec/snmp/FtpCounter32.java

ViolationLine
Private field 'type' could be made final; it is only initialized in the declaration or constructor.37
Private field 'entry' could be made final; it is only initialized in the declaration or constructor.38
Overridable method 'setInternalValue' called during object construction43
Overridable method 'setInternalValue' called during object construction48

goldengate/ftp/exec/snmp/FtpGauge32.java

ViolationLine
Private field 'type' could be made final; it is only initialized in the declaration or constructor.37
Private field 'entry' could be made final; it is only initialized in the declaration or constructor.38
Overridable method 'setInternalValue' called during object construction43
Overridable method 'setInternalValue' called during object construction48

goldengate/ftp/exec/snmp/FtpMonitoring.java

ViolationLine
Private field 'trafficCounter' could be made final; it is only initialized in the declaration or constructor.68
Non-static initializers are confusing95 - 102
Avoid if (x != y) ..; else ..;122 - 126
Overridable method 'initialize' called during object construction127
Avoid empty catch blocks161 - 162
Avoid empty catch blocks185 - 186
Switch statements should have a default label223 - 236
Switch statements should have a default label273 - 386
Avoid empty catch blocks387 - 388
Avoid empty catch blocks388 - 389

goldengate/ftp/exec/snmp/FtpPrivateMib.java

ViolationLine
Document empty method367 - 368
Document empty method378 - 379

goldengate/ftp/exec/snmp/FtpTimeTicks.java

ViolationLine
Private field 'type' could be made final; it is only initialized in the declaration or constructor.37
Private field 'entry' could be made final; it is only initialized in the declaration or constructor.38
Overridable method 'setInternalValue' called during object construction43
Overridable method 'setInternalValue' called during object construction48