PMD Results
The following document contains the results of PMD 4.3.
Files
goldengate/ftp/exec/adminssl/HttpSslHandler.java
| Violation | Line |
|---|
| Perhaps 'queryStringDecoder' could be replaced by a local variable. | 116 |
| Avoid if (x != y) ..; else ..; | 336 - 340 |
| Avoid if (x != y) ..; else ..; | 406 - 410 |
| Avoid if (x != y) ..; else ..; | 540 - 552 |
| Avoid if (x != y) ..; else ..; | 545 - 550 |
| Avoid if (x != y) ..; else ..; | 555 - 559 |
| Avoid if (x != y) ..; else ..; | 620 - 651 |
| Avoid if (x != y) ..; else ..; | 636 - 645 |
| Avoid if (x != y) ..; else ..; | 775 - 786 |
| Avoid if (x != y) ..; else ..; | 790 - 828 |
| These nested if statements could be combined | 815 - 820 |
| Avoid if (x != y) ..; else ..; | 926 - 947 |
goldengate/ftp/exec/config/AUTHUPDATE.java
| Violation | Line |
|---|
| Avoid if (x != y) ..; else ..; | 62 - 82 |
| These nested if statements could be combined | 87 - 91 |
goldengate/ftp/exec/config/FileBasedConfiguration.java
| Violation | Line |
|---|
| Perhaps 'httpsBootstrap' could be replaced by a local variable. | 597 |
| Avoid if (x != y) ..; else ..; | 646 - 651 |
| Avoid if (x != y) ..; else ..; | 658 - 666 |
| Avoid if (x != y) ..; else ..; | 682 - 698 |
| Avoid if (x != y) ..; else ..; | 701 - 705 |
| Avoid if (x != y) ..; else ..; | 710 - 715 |
| These nested if statements could be combined | 717 - 720 |
| Avoid if (x != y) ..; else ..; | 724 - 729 |
| Avoid if (x != y) ..; else ..; | 811 - 826 |
| Avoid if (x != y) ..; else ..; | 956 - 978 |
| Avoid if (x != y) ..; else ..; | 999 - 1003 |
| Avoid if (x != y) ..; else ..; | 1339 - 1353 |
| Avoid if (x != y) ..; else ..; | 1381 - 1414 |
| Avoid if (x != y) ..; else ..; | 1397 - 1413 |
| Avoid if (x != y) ..; else ..; | 1523 - 1526 |
| Avoid if (x != y) ..; else ..; | 1527 - 1530 |
| Avoid if (x != y) ..; else ..; | 1534 - 1544 |
goldengate/ftp/exec/control/ExecBusinessHandler.java
| Violation | Line |
|---|
| New exception is thrown in catch block, original stack trace may be lost | 135 |
| New exception is thrown in catch block, original stack trace may be lost | 165 |
| Avoid if (x != y) ..; else ..; | 189 - 190 |
| Avoid empty if statements | 248 - 250 |
| Avoid if (x != y) ..; else ..; | 248 - 267 |
| Avoid empty if statements | 250 - 252 |
| These nested if statements could be combined | 255 - 266 |
| These nested if statements could be combined | 256 - 265 |
| Deeply nested if..then statements are hard to read | 259 - 263 |
| Avoid if (x != y) ..; else ..; | 322 - 324 |
| Avoid if (x != y) ..; else ..; | 336 - 338 |
| Document empty method | 350 - 351 |
| Avoid if (x != y) ..; else ..; | 357 - 365 |
| Avoid if (x != y) ..; else ..; | 360 - 364 |
| These nested if statements could be combined | 370 - 373 |
| These nested if statements could be combined | 381 - 384 |
| When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 498 |
| Position literals first in String comparisons | 499 |
goldengate/ftp/exec/control/GoldenGateActionLogger.java
| Violation | Line |
|---|
| All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. | 45 - 226 |
| Deeply nested if..then statements are hard to read | 82 - 86 |
| Avoid empty catch blocks | 89 - 91 |
| Avoid if (x != y) ..; else ..; | 111 - 140 |
| Avoid empty catch blocks | 126 - 128 |
| Avoid if (x != y) ..; else ..; | 160 - 224 |
| Avoid if (x != y) ..; else ..; | 164 - 172 |
| Avoid empty catch blocks | 167 - 168 |
| Avoid empty catch blocks | 168 - 169 |
| Avoid empty catch blocks | 196 - 198 |
| These nested if statements could be combined | 206 - 209 |
| These nested if statements could be combined | 219 - 222 |
goldengate/ftp/exec/data/FileSystemBasedDataBusinessHandler.java
| Violation | Line |
|---|
| Document empty method | 43 - 44 |
| Document empty method | 54 - 55 |
| Document empty method | 65 - 66 |
| Document empty method | 76 - 77 |
goldengate/ftp/exec/database/data/DbTransferLog.java
| Violation | Line |
|---|
| Overridable method 'setToArray' called during object construction | 186 |
| Overridable method 'insert' called during object construction | 188 |
| New exception is thrown in catch block, original stack trace may be lost | 456 |
| New exception is thrown in catch block, original stack trace may be lost | 465 |
| New exception is thrown in catch block, original stack trace may be lost | 468 |
| Avoid if (x != y) ..; else ..; | 520 - 525 |
| Avoid if (x != y) ..; else ..; | 558 - 584 |
| Avoid if (x != y) ..; else ..; | 569 - 584 |
| Avoid empty catch blocks | 621 - 622 |
| Avoid empty catch blocks | 622 - 623 |
| Avoid empty catch blocks | 623 - 624 |
| Avoid empty catch blocks | 678 - 679 |
| Avoid empty catch blocks | 679 - 680 |
| Avoid empty catch blocks | 680 - 681 |
| Avoid empty catch blocks | 698 - 699 |
| Avoid empty catch blocks | 699 - 700 |
| Avoid empty catch blocks | 700 - 701 |
| Use equals() to compare object references. | 807 |
| Document empty method | 905 - 907 |
goldengate/ftp/exec/database/model/DbModelFactory.java
| Violation | Line |
|---|
| All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. | 34 - 69 |
goldengate/ftp/exec/database/model/DbModelMysql.java
| Violation | Line |
|---|
| Use block level rather than method level synchronization | 187 - 235 |
| Avoid empty catch blocks | 199 - 200 |
| Avoid empty catch blocks | 231 - 232 |
goldengate/ftp/exec/exec/AbstractExecutor.java
| Violation | Line |
|---|
| Possible unsafe assignment to a non-final static field in a constructor. | 74 |
| Avoid empty while statements | 348 - 349 |
goldengate/ftp/exec/exec/ExecuteExecutor.java
| Violation | Line |
|---|
| These nested if statements could be combined | 90 - 93 |
| New exception is thrown in catch block, original stack trace may be lost | 126 |
| New exception is thrown in catch block, original stack trace may be lost | 126 |
| New exception is thrown in catch block, original stack trace may be lost | 131 |
| New exception is thrown in catch block, original stack trace may be lost | 131 |
| New exception is thrown in catch block, original stack trace may be lost | 139 |
| New exception is thrown in catch block, original stack trace may be lost | 145 |
goldengate/ftp/exec/exec/LocalExecClient.java
| Violation | Line |
|---|
| Document empty constructor | 95 - 97 |
goldengate/ftp/exec/exec/R66PreparedTransferExecutor.java
| Violation | Line |
|---|
| When instantiating a SimpleDateFormat object, specify a Locale | 138 |
| Avoid empty catch blocks | 143 - 144 |
| New exception is thrown in catch block, original stack trace may be lost | 184 - 185 |
| New exception is thrown in catch block, original stack trace may be lost | 203 |
| New exception is thrown in catch block, original stack trace may be lost | 211 |
goldengate/ftp/exec/ExecGatewayFtpServer.java
| Violation | Line |
|---|
| All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. | 48 - 112 |
goldengate/ftp/exec/file/FileBasedAuth.java
| Violation | Line |
|---|
| Avoid empty catch blocks | 203 - 204 |
goldengate/ftp/exec/ServerInitDatabase.java
| Violation | Line |
|---|
| All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. | 42 - 122 |
| Singleton is not thread safe | 73 - 75 |
goldengate/ftp/exec/snmp/FtpCounter32.java
| Violation | Line |
|---|
| Private field 'type' could be made final; it is only initialized in the declaration or constructor. | 37 |
| Private field 'entry' could be made final; it is only initialized in the declaration or constructor. | 38 |
| Overridable method 'setInternalValue' called during object construction | 43 |
| Overridable method 'setInternalValue' called during object construction | 48 |
goldengate/ftp/exec/snmp/FtpGauge32.java
| Violation | Line |
|---|
| Private field 'type' could be made final; it is only initialized in the declaration or constructor. | 37 |
| Private field 'entry' could be made final; it is only initialized in the declaration or constructor. | 38 |
| Overridable method 'setInternalValue' called during object construction | 43 |
| Overridable method 'setInternalValue' called during object construction | 48 |
goldengate/ftp/exec/snmp/FtpMonitoring.java
| Violation | Line |
|---|
| Private field 'trafficCounter' could be made final; it is only initialized in the declaration or constructor. | 68 |
| Non-static initializers are confusing | 95 - 102 |
| Avoid if (x != y) ..; else ..; | 122 - 126 |
| Overridable method 'initialize' called during object construction | 127 |
| Avoid empty catch blocks | 161 - 162 |
| Avoid empty catch blocks | 185 - 186 |
| Switch statements should have a default label | 223 - 236 |
| Switch statements should have a default label | 273 - 386 |
| Avoid empty catch blocks | 387 - 388 |
| Avoid empty catch blocks | 388 - 389 |
goldengate/ftp/exec/snmp/FtpPrivateMib.java
| Violation | Line |
|---|
| Document empty method | 367 - 368 |
| Document empty method | 378 - 379 |
goldengate/ftp/exec/snmp/FtpTimeTicks.java
| Violation | Line |
|---|
| Private field 'type' could be made final; it is only initialized in the declaration or constructor. | 37 |
| Private field 'entry' could be made final; it is only initialized in the declaration or constructor. | 38 |
| Overridable method 'setInternalValue' called during object construction | 43 |
| Overridable method 'setInternalValue' called during object construction | 48 |
