PMD Results

The following document contains the results of PMD 4.3.

Files

goldengate/common/command/exception/CommandAbstractException.java

Violation	Line
Avoid if (x != y) ..; else ..;	61

goldengate/common/command/ReplyCode.java

Violation	Line
Avoid empty catch blocks	324 - 326

goldengate/common/cpu/GgConstraintLimitHandler.java

Violation	Line
These nested if statements could be combined	212 - 215
Avoid instantiation through private constructors from outside of the constructor's class.	380
Avoid instantiation through private constructors from outside of the constructor's class.	406

goldengate/common/crypto/DynamicKeyManager.java

Violation	Line
Avoid empty catch blocks	106 - 107
Avoid empty catch blocks	143 - 144

goldengate/common/crypto/KeyObject.java

Violation	Line
Document empty constructor	75 - 76
Avoid if (x != y) ..; else ..;	369 - 372
Avoid empty catch blocks	373 - 374

goldengate/common/crypto/ssl/GgSecureKeyStore.java

Violation	Line
Overridable method 'getKeyStorePassword' called during object construction	82
Overridable method 'initKeyManagerFactory' called during object construction	96
Overridable method 'initKeyStore' called during object construction	107
Overridable method 'initKeyStore' called during object construction	123
Avoid if (x != y) ..; else ..;	125 - 129
Overridable method 'initTrustStore' called during object construction	126
Overridable method 'initEmptyTrustStore' called during object construction	128
Avoid empty catch blocks	168 - 169
Avoid empty catch blocks	258 - 259
Avoid empty catch blocks	296 - 297
Avoid empty catch blocks	410 - 411

goldengate/common/crypto/ssl/GgSslContextFactory.java

Violation	Line
Avoid if (x != y) ..; else ..;	187 - 191

goldengate/common/database/data/AbstractDbData.java

Violation	Line
Ensure that resources like this ResultSet object are closed after use	497
Ensure that resources like this ResultSet object are closed after use	510

goldengate/common/database/data/DbDataModel.java

Violation	Line
Overridable method 'setToArray' called during object construction	230
Overridable method 'select' called during object construction	243

goldengate/common/database/data/DbValue.java

Violation	Line
A switch statement does not contain a break	271 - 289
A switch statement does not contain a break	293 - 354

goldengate/common/database/DbAdmin.java

Violation	Line
Overridable method 'validConnection' called during object construction	141
Overridable method 'validConnection' called during object construction	187
Overridable method 'validConnection' called during object construction	203
Overridable method 'validConnection' called during object construction	248
Avoid empty catch blocks	361 - 362

goldengate/common/database/DbConnectionPool.java

Violation	Line
Private field 'timeOutForceClose' could be made final; it is only initialized in the declaration or constructor.	62
No need to check for null before an instanceof	88
Use block level rather than method level synchronization	154 - 164
Avoid instantiation through private constructors from outside of the constructor's class.	202
Use block level rather than method level synchronization	278 - 292
Ensure that resources like this Connection object are closed after use	328
These nested if statements could be combined	333
Use block level rather than method level synchronization	338 - 366
Avoid if (x != y) ..; else ..;	346 - 350
Ensure that resources like this Connection object are closed after use	352
Use block level rather than method level synchronization	368 - 389
Use block level rather than method level synchronization	391 - 399
Avoid empty catch blocks	404 - 406
Use block level rather than method level synchronization	442 - 444

goldengate/common/database/DbPreparedStatement.java

Violation	Line
New exception is thrown in catch block, original stack trace may be lost	136 - 137
New exception is thrown in catch block, original stack trace may be lost	190 - 191
New exception is thrown in catch block, original stack trace may be lost	237 - 239
Avoid empty catch blocks	339 - 340

goldengate/common/database/DbRequest.java

Violation	Line
New exception is thrown in catch block, original stack trace may be lost	100 - 101
Ensure that resources like this ResultSet object are closed after use	197

goldengate/common/database/DbSession.java

Violation	Line
Use block level rather than method level synchronization	92 - 99

goldengate/common/database/model/DbModelAbstract.java

Violation	Line
Avoid empty catch blocks	70 - 71
Avoid empty catch blocks	88 - 89
These nested if statements could be combined	102 - 105
An instanceof check is being performed on the caught exception. Create a separate catch clause for this exception type.	115
New exception is thrown in catch block, original stack trace may be lost	135 - 136
Avoid empty catch blocks	143 - 145
Ensure that resources like this ResultSet object are closed after use	161
Avoid empty catch blocks	188 - 190
New exception is thrown in catch block, original stack trace may be lost	196 - 197
Ensure that resources like this ResultSet object are closed after use	201
New exception is thrown in catch block, original stack trace may be lost	208 - 209
Avoid empty catch blocks	219 - 220
New exception is thrown in catch block, original stack trace may be lost	222 - 223
Avoid empty catch blocks	230 - 232
Avoid empty catch blocks	240 - 241
Document empty method	262 - 263
An empty method in an abstract class should be abstract instead	262 - 263

goldengate/common/database/model/DbModelFactory.java

Violation	Line
All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning.	33 - 80

goldengate/common/database/model/DbModelH2.java

Violation	Line
Possible unsafe assignment to a non-final static field in a constructor.	57

goldengate/common/database/model/DbModelMysql.java

Violation	Line
Possible unsafe assignment to a non-final static field in a constructor.	61
Possible unsafe assignment to a non-final static field in a constructor.	62
Avoid empty catch blocks	135 - 136
Use block level rather than method level synchronization	347 - 395
Avoid empty catch blocks	359 - 360
Avoid empty catch blocks	391 - 392

goldengate/common/database/model/DbModelOracle.java

Violation	Line
Possible unsafe assignment to a non-final static field in a constructor.	60
Possible unsafe assignment to a non-final static field in a constructor.	61
Avoid empty catch blocks	153 - 154

goldengate/common/file/AbstractDir.java

Violation	Line
Singleton is not thread safe	75 - 81
Position literals first in String comparisons	195
Position literals first in String comparisons	197

goldengate/common/file/DataBlock.java

Violation	Line
Document empty constructor	83 - 84

goldengate/common/file/DataBlockSizeEstimator.java

Violation	Line
Private field 'internal' could be made final; it is only initialized in the declaration or constructor.	34

goldengate/common/file/filesystembased/FilesystemBasedDirImpl.java

Violation	Line
An empty method in an abstract class should be abstract instead	496 - 499
Avoid if (x != y) ..; else ..;	514 - 517
Avoid empty catch blocks	619 - 620
Avoid if (x != y) ..; else ..;	638 - 641
New exception is thrown in catch block, original stack trace may be lost	652
New exception is thrown in catch block, original stack trace may be lost	683
Avoid empty while statements	686 - 687
New exception is thrown in catch block, original stack trace may be lost	690
New exception is thrown in catch block, original stack trace may be lost	702
New exception is thrown in catch block, original stack trace may be lost	714

goldengate/common/file/filesystembased/FilesystemBasedFileImpl.java

Violation	Line
Overridable method 'getFileFromPath' called during object construction	111
Overridable method 'setPosition' called during object construction	114
Overridable method 'setPosition' called during object construction	121
Avoid empty catch blocks	122 - 123
Avoid empty catch blocks	211 - 212
Avoid empty catch blocks	225 - 227
New exception is thrown in catch block, original stack trace may be lost	228
New exception is thrown in catch block, original stack trace may be lost	360
Avoid empty catch blocks	363 - 364
Avoid empty catch blocks	520 - 521
New exception is thrown in catch block, original stack trace may be lost	524
Avoid if (x != y) ..; else ..;	569 - 576
Avoid empty catch blocks	594 - 595
New exception is thrown in catch block, original stack trace may be lost	596
Avoid empty catch blocks	602 - 603
Avoid empty catch blocks	614 - 615
Avoid empty catch blocks	659 - 660

goldengate/common/file/filesystembased/FilesystemBasedOptsMLSxImpl.java

Violation	Line
Document empty constructor	81 - 82

goldengate/common/file/filesystembased/specific/FilesystemBasedCommonsIo.java

Violation	Line
All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning.	36 - 59

goldengate/common/file/passthrough/PassthroughBasedDirImpl.java

Violation	Line
Avoid empty catch blocks	77 - 78
New exception is thrown in catch block, original stack trace may be lost	111 - 112
New exception is thrown in catch block, original stack trace may be lost	117 - 118
Consider simply returning the value vs storing it in local variable 'file'	158
New exception is thrown in catch block, original stack trace may be lost	187
New exception is thrown in catch block, original stack trace may be lost	211
New exception is thrown in catch block, original stack trace may be lost	218
New exception is thrown in catch block, original stack trace may be lost	237
New exception is thrown in catch block, original stack trace may be lost	244
New exception is thrown in catch block, original stack trace may be lost	255
New exception is thrown in catch block, original stack trace may be lost	266
New exception is thrown in catch block, original stack trace may be lost	278
New exception is thrown in catch block, original stack trace may be lost	283
New exception is thrown in catch block, original stack trace may be lost	293
New exception is thrown in catch block, original stack trace may be lost	298
New exception is thrown in catch block, original stack trace may be lost	309
New exception is thrown in catch block, original stack trace may be lost	314
New exception is thrown in catch block, original stack trace may be lost	325
New exception is thrown in catch block, original stack trace may be lost	330
An empty method in an abstract class should be abstract instead	339 - 342
New exception is thrown in catch block, original stack trace may be lost	349
New exception is thrown in catch block, original stack trace may be lost	387
New exception is thrown in catch block, original stack trace may be lost	392
New exception is thrown in catch block, original stack trace may be lost	401
New exception is thrown in catch block, original stack trace may be lost	406
New exception is thrown in catch block, original stack trace may be lost	415
New exception is thrown in catch block, original stack trace may be lost	420

goldengate/common/file/passthrough/PassthroughBasedFileImpl.java

Violation	Line
Overridable method 'getFileFromPath' called during object construction	120
New exception is thrown in catch block, original stack trace may be lost	124
Overridable method 'setPosition' called during object construction	128
Overridable method 'setPosition' called during object construction	134
Avoid empty catch blocks	135 - 136
New exception is thrown in catch block, original stack trace may be lost	204
New exception is thrown in catch block, original stack trace may be lost	283
New exception is thrown in catch block, original stack trace may be lost	295
New exception is thrown in catch block, original stack trace may be lost	311
Avoid empty catch blocks	314 - 315
Avoid empty catch blocks	404 - 405
New exception is thrown in catch block, original stack trace may be lost	432
Avoid empty catch blocks	438 - 439
Avoid empty catch blocks	461 - 462
New exception is thrown in catch block, original stack trace may be lost	487
Avoid empty catch blocks	493 - 494

goldengate/common/future/GgCompletedFuture.java

Violation	Line
An empty method in an abstract class should be abstract instead	69 - 71
An empty method in an abstract class should be abstract instead	74 - 76
An empty method in an abstract class should be abstract instead	79 - 81
An empty method in an abstract class should be abstract instead	84 - 86
An empty method in an abstract class should be abstract instead	89 - 91
An empty method in an abstract class should be abstract instead	94 - 96
An empty method in an abstract class should be abstract instead	99 - 101

goldengate/common/future/GgFailedFuture.java

Violation	Line
Use block level rather than method level synchronization	49 - 51
Use block level rather than method level synchronization	54 - 56

goldengate/common/future/GgFuture.java

Violation	Line
Use block level rather than method level synchronization	70 - 72
Use block level rather than method level synchronization	80 - 82
Use block level rather than method level synchronization	90 - 92
Use block level rather than method level synchronization	99 - 104
Use equals() to compare object references.	100
Use block level rather than method level synchronization	112 - 114
Use equals() to compare object references.	113
New exception is thrown in catch block, original stack trace may be lost	241
New exception is thrown in catch block, original stack trace may be lost	259

goldengate/common/future/GgSucceededFuture.java

Violation	Line
Use block level rather than method level synchronization	33 - 35
Use block level rather than method level synchronization	38 - 40

goldengate/common/logging/GgInternalLogger.java

Violation	Line
Non-static initializers are confusing	54 - 56

goldengate/common/lru/SynchronizedLruCache.java

Violation	Line
Use block level rather than method level synchronization	88 - 90
Use block level rather than method level synchronization	93 - 95
Use block level rather than method level synchronization	108 - 110
Use block level rather than method level synchronization	112 - 114
Use block level rather than method level synchronization	122 - 124
Use block level rather than method level synchronization	127 - 137

goldengate/common/state/example/ExampleUsageMachineState.java

Violation	Line
All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning.	39 - 107

goldengate/common/tar/TarUtility.java

Violation	Line
All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning.	43 - 298
Avoid empty catch blocks	67 - 69
Avoid empty catch blocks	74 - 76
Avoid empty catch blocks	79 - 81
Avoid empty catch blocks	84 - 86
Avoid empty catch blocks	141 - 143
Avoid empty catch blocks	149 - 151
Avoid empty catch blocks	154 - 156
Avoid empty catch blocks	159 - 161
Avoid empty catch blocks	186 - 188
Avoid empty catch blocks	194 - 196
Avoid empty catch blocks	199 - 201
Avoid empty catch blocks	204 - 206

goldengate/common/tar/ZipUtility.java

Violation	Line
All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning.	43 - 294
Avoid empty catch blocks	67 - 69
Avoid empty catch blocks	74 - 76
Avoid empty catch blocks	79 - 81
Avoid empty catch blocks	84 - 86
Avoid empty catch blocks	139 - 141
Avoid empty catch blocks	147 - 149
Avoid empty catch blocks	152 - 154
Avoid empty catch blocks	157 - 159
Avoid empty catch blocks	182 - 184
Avoid empty catch blocks	190 - 192
Avoid empty catch blocks	195 - 197
Avoid empty catch blocks	200 - 202

goldengate/common/utility/GgStringUtils.java

Violation	Line
All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning.	47 - 231
When instantiating a SimpleDateFormat object, specify a Locale	105
Static DateFormatter objects should be accessed in a synchronized manner	120
Static DateFormatter objects should be accessed in a synchronized manner	146
Deeply nested if..then statements are hard to read	149 - 151
New exception is thrown in catch block, original stack trace may be lost	191
Avoid empty while statements	217 - 218

goldengate/common/utility/GgThreadFactory.java

Violation	Line
Private field 'GlobalName' could be made final; it is only initialized in the declaration or constructor.	31
Private field 'counter' could be made final; it is only initialized in the declaration or constructor.	32
Consider simply returning the value vs storing it in local variable 'thread'	40

goldengate/common/xml/XmlHash.java

Violation	Line
Overridable method 'put' called during object construction	43

goldengate/common/xml/XmlStaticShared.java

Violation	Line
When instantiating a SimpleDateFormat object, specify a Locale	38 - 39
When instantiating a SimpleDateFormat object, specify a Locale	42 - 43
When instantiating a SimpleDateFormat object, specify a Locale	46 - 47
Non-static initializers are confusing	48 - 52

goldengate/common/xml/XmlType.java

Violation	Line
Switch statements should have a default label	63 - 100

goldengate/common/xml/XmlUtil.java

Violation	Line
All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning.	52 - 1011
These nested if statements could be combined	808 - 814
These nested if statements could be combined	818 - 824
These nested if statements could be combined	933 - 942
These nested if statements could be combined	946 - 963
Avoid if (x != y) ..; else ..;	998 - 1002
Avoid empty catch blocks	1008 - 1009

goldengate/common/xml/XmlValue.java

Violation	Line
Switch statements should have a default label	69 - 103
Overridable method 'getType' called during object construction	69
Overridable method 'addValue' called during object construction	129
Overridable method 'getType' called during object construction	129
Overridable method 'setValue' called during object construction	136
Avoid empty catch blocks	137 - 139
Switch statements should have a default label	222 - 274
Avoid using java.lang.ThreadGroup; it is not thread safe	318
A switch statement does not contain a break	360 - 390
Avoid instantiating Boolean objects; reference Boolean.TRUE or Boolean.FALSE or call Boolean.valueOf() instead.	362
Avoid using java.lang.ThreadGroup; it is not thread safe	378
Avoid if (x != y) ..; else ..;	567 - 576
Avoid if (x != y) ..; else ..;	568 - 572
Avoid using java.lang.ThreadGroup; it is not thread safe	618
Position literals first in String comparisons	675
Avoid using java.lang.ThreadGroup; it is not thread safe	743
Avoid using java.lang.ThreadGroup; it is not thread safe	761
New exception is thrown in catch block, original stack trace may be lost	769 - 770
Avoid if (x != y) ..; else ..;	777 - 778
Avoid if (x != y) ..; else ..;	778

GoldenGate Common

Project Documentation

PMD Results

Files

goldengate/common/command/exception/CommandAbstractException.java

goldengate/common/command/ReplyCode.java

goldengate/common/cpu/GgConstraintLimitHandler.java

goldengate/common/crypto/DynamicKeyManager.java

goldengate/common/crypto/KeyObject.java

goldengate/common/crypto/ssl/GgSecureKeyStore.java

goldengate/common/crypto/ssl/GgSslContextFactory.java

goldengate/common/database/data/AbstractDbData.java

goldengate/common/database/data/DbDataModel.java

goldengate/common/database/data/DbValue.java

goldengate/common/database/DbAdmin.java

goldengate/common/database/DbConnectionPool.java

goldengate/common/database/DbPreparedStatement.java

goldengate/common/database/DbRequest.java

goldengate/common/database/DbSession.java

goldengate/common/database/model/DbModelAbstract.java

goldengate/common/database/model/DbModelFactory.java

goldengate/common/database/model/DbModelH2.java

goldengate/common/database/model/DbModelMysql.java

goldengate/common/database/model/DbModelOracle.java

goldengate/common/file/AbstractDir.java

goldengate/common/file/DataBlock.java

goldengate/common/file/DataBlockSizeEstimator.java

goldengate/common/file/filesystembased/FilesystemBasedDirImpl.java

goldengate/common/file/filesystembased/FilesystemBasedFileImpl.java

goldengate/common/file/filesystembased/FilesystemBasedOptsMLSxImpl.java

goldengate/common/file/filesystembased/specific/FilesystemBasedCommonsIo.java

goldengate/common/file/passthrough/PassthroughBasedDirImpl.java

goldengate/common/file/passthrough/PassthroughBasedFileImpl.java

goldengate/common/future/GgCompletedFuture.java

goldengate/common/future/GgFailedFuture.java

goldengate/common/future/GgFuture.java

goldengate/common/future/GgSucceededFuture.java

goldengate/common/logging/GgInternalLogger.java

goldengate/common/lru/SynchronizedLruCache.java

goldengate/common/state/example/ExampleUsageMachineState.java

goldengate/common/tar/TarUtility.java

goldengate/common/tar/ZipUtility.java

goldengate/common/utility/GgStringUtils.java

goldengate/common/utility/GgThreadFactory.java

goldengate/common/xml/XmlHash.java

goldengate/common/xml/XmlStaticShared.java

goldengate/common/xml/XmlType.java

goldengate/common/xml/XmlUtil.java

goldengate/common/xml/XmlValue.java